Implement initial feature flag support #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efahk
requested review from
hans-lizihan,
jaredmixpanel,
msiebert and
tdumitrescu
efahk
commented
Aug 27, 2025
msiebert
reviewed
Aug 29, 2025
tdumitrescu
reviewed
Sep 2, 2025
added 7 commits
September 4, 2025 17:17
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
hans-lizihan
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a first pass at implement server-side SDK for feature flags.
It introduces two modes for evaluating feature flags, Remote Evaluation and Local Evaluation. The API contract was kept as close to the client SDKs' as it made sense to. See demo.py for some sample usage. I'd love feedback on the API ergonomics
Remote Evaluation
Provides methods, get_variant_value, get_variant, is_enabled more, aligning the API to the client SDK's as close as it made sense to. Each method makes an outbound call to the flag service for evaluation.
Local Evaluation
Flag Definitions are polled from the server and stored on the SDK. Assignment is run by the SDK itself.