[WIP] Move Mink toward 2.0 #542
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2014
stof
force-pushed
the
2-architecture-changes
branch
2 times, most recently
from
77f4cc5 to
3ba6487
Compare
stof
force-pushed
the
2-architecture-changes
branch
from
3ba6487 to
592d63a
Compare
This was referenced Feb 4, 2015
stof
force-pushed
the
2-architecture-changes
branch
from
592d63a to
a0498b5
Compare
stof
force-pushed
the
2-architecture-changes
branch
from
a0498b5 to
de0733b
Compare
stof
force-pushed
the
2-architecture-changes
branch
2 times, most recently
from
2f6d0fc to
e42b0c4
Compare
stof
force-pushed
the
2-architecture-changes
branch
from
e42b0c4 to
3f18b3b
Compare
stof
force-pushed
the
2-architecture-changes
branch
from
3f18b3b to
3774182
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
============================================
+ Coverage 98.56% 99.88% +1.31%
+ Complexity 389 366 -23
============================================
Files 24 23 -1
Lines 909 849 -60
============================================
- Hits 896 848 -48
+ Misses 13 1 -12 ☔ View full report in Codecov by Sentry. |
stof
force-pushed
the
2-architecture-changes
branch
2 times, most recently
from
134be2e to
3b01db6
Compare
stof
force-pushed
the
2-architecture-changes
branch
from
3b01db6 to
4701c9d
Compare
…_button` selector
The constructor now receives the driver and the element finder instead of the session.
This avoids a circular dependency. The driver interface now returns an array of XPath for found elements, and Element::find() instantiates the NodeElement for them. The driver is now the low level API which does not depend on any other part of Mink (but used by other parts). The ElementFinder is responsible for instantiating the NodeElement.
stof
force-pushed
the
2-architecture-changes
branch
from
4701c9d to
d8a4413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the updated version of #427 targetting the master branch.
See #415 for the goals of the change