Finalizes customEditorPriority proposal. Closes https://github.com/microsoft/vscode/issues/292379 - #329002
Merged
Merged
Conversation
Henning Dieterichs (hediet)
enabled auto-merge (squash)
August 4, 2026 16:25
Copilot started reviewing on behalf of
Henning Dieterichs (hediet)
August 4, 2026 16:25
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Finalizes per-editor custom editor priorities by promoting textEditor and diffEditor priority configuration to stable behavior.
Changes:
- Removes the proposal registration and declaration file.
- Removes proposal gating from priority handling.
- Updates Markdown’s enabled API proposals.
Show a summary per file
| File | Description |
|---|---|
src/vscode-dts/vscode.proposed.customEditorPriority.d.ts |
Removes the finalized proposal stub. |
src/vs/workbench/contrib/customEditor/common/contributedCustomEditors.ts |
Enables per-editor priorities without proposal gating. |
src/vs/platform/extensions/common/extensionsApiProposals.ts |
Removes the proposal registration. |
extensions/markdown-language-features/package.json |
Removes the finalized proposal opt-in. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Balanced
Paul (pwang347)
approved these changes
Aug 4, 2026
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Aug 4, 2026
* origin/main: (31 commits) Improve workspace picker preselection (#328995) agentHost: support Codex custom agents and runtime enablement (#328956) Finalizes customEditorPriority proposal. Closes #292379 (#329002) Add Agents window startup A/A experiment trigger (#328454) sessions: show created session pill in response summary (#328984) Fix onboarding microphone picker visibility (#329011) Explains how to develop the markdown editor (#329009) Conditional agent-window auth for signed-out users (#328990) Fix BYOK enterprise policy handling in agent host Agent Host changes for fix/agent-host-byok-enterprise-policy agentHost: drive tool execution from the session input queue (#328989) Make Integrated Browser smoke tests deterministic across build qualities (#328983) Accept box sizing screenshot changes Avoid large Component Fixtures step outputs Remove component fixture box sizing reset fix: guard stale line numbers in test decorations (fixes #328988) sessions: fix maximized side pane toggle (#328974) Add component fixture rendering controls Reduce floating panel margins for layout consistency (#328963) agentHost: support file completions across workspace roots (#328944) ... # Conflicts: # src/vs/sessions/SESSIONS.md # src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #292379