Remove obsolete maybeMigrateCurrentSession method #280042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was used to migrate sessions from the old edits view that no longer exists in VS Code. The migration logic: - Checked for an old 'edits' memento - Copied the sessionId to the unified view state - Migrated input state and mode settings - Set a hasMigratedCurrentSession flag Since the edits view has been removed, this migration path is no longer needed and can be safely deleted. Changes: - Removed maybeMigrateCurrentSession() method (27 lines) - Removed hasMigratedCurrentSession flag from IChatViewPaneState interface - Removed method call from constructor Fixes microsoft#280040
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
Author
|
@microsoft-github-policy-service agree |
bpasero
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Obsolete Session Migration Code
Summary
This PR removes the obsolete
maybeMigrateCurrentSession()method and related code that was used to migrate chat sessions from the now-removed edits view to the unified chat view.Background
VS Code previously had a separate "edits view" for chat sessions. When that view was removed and unified into the main chat view, a migration path was created to move users' sessions over. The
maybeMigrateCurrentSession()method handled this one-time migration.Since sufficient time has passed and the edits view no longer exists, this migration code is no longer necessary and can be safely removed.
Changes
This PR removes:
maybeMigrateCurrentSession()method (lines 121-144, 27 lines total)hasMigratedCurrentSessionflag fromIChatViewPaneStateinterfaceMethod call from constructor (line 116)
this.maybeMigrateCurrentSession()during initializationTesting
Fixes
#280040