Skip to content

Conversation

@SimonSiefke
Copy link
Contributor

Fixes a memory leak in startup page.

There only seems to be one global StartupPageEditorResolverContribution instance. Registering disposables to the class adds them to that instance, but being a global instance instance, the disposables are never disposed.

Before

When opening and closing a getting started editor, the number GettingStartedInputs grows each time:

getting-started

After

No more leaks are detected

{
  "namedFunctionCount3": [],
  "isLeak": false
}
@bpasero bpasero enabled auto-merge (squash) November 24, 2025 05:27
@bpasero bpasero added this to the November 2025 milestone Nov 24, 2025
@bpasero bpasero merged commit eb1831a into microsoft:main Nov 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants