Testing - Uncompleted result should be marked as skipped #273742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where tests that were enqueued but never completed were marked as "Unset" instead of "Skipped" when the test run finished. The change ensures that any tests left in Queued or Running state are properly marked as Skipped when the test task completes, providing clearer feedback about which tests were not executed.
Key changes:
- Changed the default state for uncompleted tests from
TestResultState.UnsettoTestResultState.Skippedin themarkComplete()method - Added a test case to verify that enqueued but never completed tests are marked as skipped
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/testing/common/testResult.ts | Changed the state assignment for uncompleted tests from Unset to Skipped when marking a test task as complete |
| src/vs/workbench/contrib/testing/test/common/testResultService.test.ts | Added test case to verify enqueued tests are marked as skipped when the test run completes |
Member
|
Looks like status checks failed |
Member
Author
|
Fixed. Looks like my test was a duplicate of the one above ^^ |
connor4312
approved these changes
Oct 28, 2025
Member
|
thanks! |
mjbvz
approved these changes
Oct 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #272888