Fix memory leak in InlineEditsGutterIndicator (#273549) #273550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory leak in the InlineEditsGutterIndicator component by ensuring proper cleanup of observables. Each time the _state derived observable is recomputed, it creates a new observeLineOffsetRange observable but was not disposing the previous one, causing resources to accumulate.
Key Changes:
- Added a
_stateDisposablesfield to track disposables created within the derived observable - Implemented cleanup logic to dispose previous disposables before creating new ones
.../editor/contrib/inlineCompletions/browser/view/inlineEdits/components/gutterIndicatorView.ts
Outdated
Show resolved
Hide resolved
Member
|
Thanks for the PR! |
Tyriar
approved these changes
Oct 28, 2025
hediet
approved these changes
Oct 28, 2025
.../editor/contrib/inlineCompletions/browser/view/inlineEdits/components/gutterIndicatorView.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up previous observable every time we create a new one.
Fixes #273549