Add dotenv support

[remcohaszing]

This adds basic language support for the dotenv language. This includes syntax highlighting and a language configuration file.

The dotenv language is applied to files with the .env extension, files named .env, .flaskenv, or user-dirs.dirs, and file names starting with .env..

The grammar is downloaded from https://github.com/dotenv-org/dotenv-vscode.

Closes #267333
Closes #267355

[remcohaszing]

I’m not sure if I’m also supposed to update ThirdPartyNotices.txt manually or make any other changes elsewhere.

[alexr00]

@remcohaszing I'm seeing a schema validation issue in language-configuration.json:

[remcohaszing]

I noticed this too. It’s a bug in the JSON schema. This affects all language-configuration.json files. I tried tweaking this line, but it doesn’t seem to make a difference.

vscode/src/vs/workbench/contrib/codeEditor/common/languageConfigurationExtensionPoint.ts

Line 550 in c7e7ef5

type: 'object',

[alexr00]

Thanks for the PR. I have a few comments. Not sure if we want to conflict with shellscript and ini.

[alexr00]

Alright, one last question: why is this change better than using the existing shellscript grammar to highlight dotenv files?

[remcohaszing]

Dotenv is a strict subset. Only variable assignments and comments are allowed.

You can also use the TypeScript grammar to highlight JavaScript files, or the TypeScript, JavaScript, or YAML grammar to highlight JSON files. Their results would be fine, as long as the content is valid JSON.

Besides syntax highlighting it’s nice to have a builtin defined language ID that extensions can hook into. For example dotenv-vscode provides cloaking capabilities and vscode-icons provides a dedicated dotenv icon.

Given your question and the loose ressemblence based on which dotenv files were marked as properties or shellscript, I am surprised #105371 was rejected.

[joaomoreno]

@microsoft-github-policy-service rerun