Skip to content

Conversation

@avarayr
Copy link
Contributor

@avarayr avarayr commented Oct 7, 2025

fixes: #270188
image

⚠️ important notes:

Electron will (sometime in the near future) bump their build workflow to build on MacOS 26 Tahoe, which uses XCode 26.
Apps built with XCode 26 will have even bigger corner radius, here's an example

image

electron preparing for xcode26 is tracked here: electron/electron#47514

So this will be revisited in the future to increase even more (possibly to 18px?)

Copilot AI review requested due to automatic review settings October 7, 2025 16:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates VS Code's macOS styling to handle the increased border radius introduced in macOS Tahoe (version 25+). It adds detection for macOS Tahoe and applies 12px border radius instead of the 10px used for Big Sur and later versions.

Key changes:

  • Added isTahoeOrNewer function to detect macOS Tahoe (version 25+)
  • Updated workbench class detection to apply macos-tahoe-or-newer CSS class
  • Applied 12px border radius styling for Tahoe across workbench, statusbar, and process explorer components

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/vs/base/common/platform.ts Added isTahoeOrNewer function to detect macOS version 25+
src/vs/workbench/electron-browser/desktop.main.ts Updated class detection logic to apply macos-tahoe-or-newer class for Tahoe
src/vs/workbench/browser/media/style.css Added 12px border radius for main workbench on Tahoe
src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css Added 12px border radius for statusbar on Tahoe
src/vs/workbench/contrib/processExplorer/browser/media/processExplorer.css Added 12px border radius for process explorer on Tahoe
@vs-code-engineering
Copy link

vs-code-engineering bot commented Oct 7, 2025

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/browser/media/style.css
  • src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css
  • src/vs/workbench/electron-browser/desktop.main.ts
@deepak1556
Copy link
Collaborator

Thanks for linking the upstream issue, the table in their is slightly incorrect

VSCode based on Chromium 138 is built with 15.4 SDK (Electron 37)
Chromium 140-142 are built with 15.5 SDK (Electron 38 and 39)
Chromium >143 are built with 26.0 SDK (will be in Electron 40)

Unsure if there are corner radii changes between 15.4 and 15.5, but we can revisit the values over every Electron update till v40.

deepak1556
deepak1556 previously approved these changes Oct 8, 2025
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

return ['macos-tahoe-or-newer'];
}
if (isBigSurOrNewer(this.configuration.os.release)) {
return ['macos-bigsur-or-newer'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepak1556 this class name isn't the best anymore as it won't be present when the version is tahoe, despite tahoe being bigsur or newer.

Copy link
Contributor Author

@avarayr avarayr Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose removing the -or-newer suffix and opting for macos-rounded-bigsur, macos-rounded-tahoe that sort of resembles tailwind-esque classes. But I'm not sure how worth it is.

Plus having macos-rounded-bigsur sounds fine even when running on Sequoia, because sequoia inherits bigsur border radius so it checks out

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I think we can rewrite the logic to match the version table we currently support on macOS

if (isMacintosh) {
  if (isTahoeOrNewer(this.configuration.os.release)) {
       return ['macos-rounded-tahoe'];
  } else {
       return ['macos-rounded-default'];
  }
@deepak1556 deepak1556 merged commit 2d66ead into microsoft:main Oct 8, 2025
17 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants