-
Notifications
You must be signed in to change notification settings - Fork 37.2k
fix: Increase workbench border radius on macos tahoe #270236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Increase workbench border radius on macos tahoe #270236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates VS Code's macOS styling to handle the increased border radius introduced in macOS Tahoe (version 25+). It adds detection for macOS Tahoe and applies 12px border radius instead of the 10px used for Big Sur and later versions.
Key changes:
- Added
isTahoeOrNewerfunction to detect macOS Tahoe (version 25+) - Updated workbench class detection to apply
macos-tahoe-or-newerCSS class - Applied 12px border radius styling for Tahoe across workbench, statusbar, and process explorer components
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/base/common/platform.ts |
Added isTahoeOrNewer function to detect macOS version 25+ |
src/vs/workbench/electron-browser/desktop.main.ts |
Updated class detection logic to apply macos-tahoe-or-newer class for Tahoe |
src/vs/workbench/browser/media/style.css |
Added 12px border radius for main workbench on Tahoe |
src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css |
Added 12px border radius for statusbar on Tahoe |
src/vs/workbench/contrib/processExplorer/browser/media/processExplorer.css |
Added 12px border radius for process explorer on Tahoe |
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
|
Thanks for linking the upstream issue, the table in their is slightly incorrect VSCode based on Chromium 138 is built with 15.4 SDK (Electron 37) Unsure if there are corner radii changes between 15.4 and 15.5, but we can revisit the values over every Electron update till v40. |
deepak1556
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
| return ['macos-tahoe-or-newer']; | ||
| } | ||
| if (isBigSurOrNewer(this.configuration.os.release)) { | ||
| return ['macos-bigsur-or-newer']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepak1556 this class name isn't the best anymore as it won't be present when the version is tahoe, despite tahoe being bigsur or newer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose removing the -or-newer suffix and opting for macos-rounded-bigsur, macos-rounded-tahoe that sort of resembles tailwind-esque classes. But I'm not sure how worth it is.
Plus having macos-rounded-bigsur sounds fine even when running on Sequoia, because sequoia inherits bigsur border radius so it checks out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I think we can rewrite the logic to match the version table we currently support on macOS
if (isMacintosh) {
if (isTahoeOrNewer(this.configuration.os.release)) {
return ['macos-rounded-tahoe'];
} else {
return ['macos-rounded-default'];
}
fixes: #270188

Electron will (sometime in the near future) bump their build workflow to build on MacOS 26 Tahoe, which uses XCode 26.
Apps built with XCode 26 will have even bigger corner radius, here's an example
electron preparing for xcode26 is tracked here: electron/electron#47514
So this will be revisited in the future to increase even more (possibly to 18px?)