Revert "fix: confirm response based on promise (#263894)" #264047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f24cee. It broke tool calling: microsoft#264023. I also need to re-asses how I missed this during testing.
Member
Author
|
Converting to draft while I investigate root cause/fix. If there's urgency to get this revert in, please ping me offline. |
Member
Author
|
Superceded by linked PR with fix. |
Member
Author
|
There's still some issues in my attempt to fix (#264073), so re-opened this revert and will start fresh next week to get the functional behavior we desire. |
karthiknadig
approved these changes
Aug 29, 2025
TylerLeonhardt
approved these changes
Aug 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6f24cee.
It broke tool calling UI status: #264023.
I attempted to fix it (#264073) but still have some edge cases not working and will need more time to get to the bottom of it.