Add the ability to clear a ChatResponseStream, passing in a reason which results in a warning being displayed #257271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwangxx
force-pushed
the
add-ChatResponseStream-clear
branch
from
6059f7d to
e253b79
Compare
jwangxx
force-pushed
the
add-ChatResponseStream-clear
branch
from
e253b79 to
f5511a6
Compare
roblourens
reviewed
Jul 24, 2025
jwangxx
force-pushed
the
add-ChatResponseStream-clear
branch
from
7a25adc to
9f0960a
Compare
roblourens
reviewed
Jul 30, 2025
jwangxx
force-pushed
the
add-ChatResponseStream-clear
branch
from
9f0960a to
1d080b3
Compare
…ich results in a warning being displayed
…usToolInvocation and only clearing up to the last tool invocation
jwangxx
force-pushed
the
add-ChatResponseStream-clear
branch
from
1d080b3 to
b24fdb2
Compare
roblourens
added
candidate
roblourens
approved these changes
Aug 1, 2025
rzhao271
approved these changes
Aug 1, 2025
auto-merge was automatically disabled
August 1, 2025 23:08
Pull request was closed
roblourens
pushed a commit
that referenced
this pull request
Aug 2, 2025
…ich results in a warning being displayed (#257271) * Add the ability to clear a ChatResponseStream, passing in a reason which results in a warning being displayed * Changing ChatResponseStream.clear to ChatResponseStream.clearToPreviousToolInvocation and only clearing up to the last tool invocation * Remove unnecessary code block
roblourens
added a commit
that referenced
this pull request
Aug 4, 2025
…ich results in a warning being displayed (#257271) (#259370) * Add the ability to clear a ChatResponseStream, passing in a reason which results in a warning being displayed * Changing ChatResponseStream.clear to ChatResponseStream.clearToPreviousToolInvocation and only clearing up to the last tool invocation * Remove unnecessary code block Co-authored-by: James Wang <120431051+jwangxx@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to clear a ChatResponseStream, passing in a reason which results in a warning being displayed.
The corresponding issue is #257434