Skip to content

Revert "refactor: remove redundant actionRunner override in ChatEditorOverlayWidget" #255456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bpasero merged 1 commit into from
Jul 12, 2025
Merged

Revert "refactor: remove redundant actionRunner override in ChatEditorOverlayWidget" #255456

bpasero merged 1 commit into from
Jul 12, 2025

Conversation

@yamachu
Copy link
Contributor

@yamachu yamachu commented Jul 11, 2025

Reverts #254797
fix: #255438

The following methods were used to verify this

  1. open /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js
  2. Edit and insert get actionRunner(){return super.actionRunner;} on line 2074 Col 18701
@bpasero bpasero added this to the July 2025 milestone Jul 12, 2025
@bpasero bpasero merged commit 3e2b7a1 into microsoft:main Jul 12, 2025
17 checks passed
@yamachu yamachu deleted the revert-254797-ben/daily-mockingbird branch July 13, 2025 00:15
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@yamachu @bpasero @TylerLeonhardt