Fix notebook inline values when using language provider #254264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems microsoft#240731 broke inline values from language providers by only updating decorations from the fallback code.
Contributor
Author
|
@dbaeumer Sorry to tag you in this, but it's somewhat LSP-related, and I suspect @Yoyokrazy might be out. I was hoping to get this fix into the July 2025 release. |
Collaborator
|
Hi @martijnwalraven, you guessed right with my being out last week 😅 I'll review the PR this week, I think it looks good but just want to do some quick testing! Thanks for the contribution! |
Yoyokrazy
approved these changes
Jul 25, 2025
Collaborator
Yoyokrazy
left a comment
Yoyokrazy
left a comment
There was a problem hiding this comment.
The changes look good! It seems like during the fallback improvements I duplicated inlineDecorations: IModelDeltaDecoration[] and shifted the updateing of decorations, so this fix is spot on.
Thanks again for the contribution!
Tyriar
approved these changes
Jul 25, 2025
Contributor
Author
|
Thanks for merging the fix — perfect timing for the July 2025 release! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems #240731 broke inline values from language providers by only updating decorations from the fallback code.
@Yoyokrazy Since this was your PR, you might be best suited to review this.