vscode api: Raise compatibility to webview content #253635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The webview (or its `acquireVsCodeApi` injector) adds the vscode api but also deletes the properties `window.parent`, `window.top` and `window.frameElement`. This voilates the HTML Spec and makes problems with some code like `if (window.parent === window)` to detect if we are running in an iframe. Yes, this affects Hyrum's Law and https://xkcd.com/1172/ but detecting `acquireVsCodeApi` object itself feels to be cleaner anyway.
mjbvz
approved these changes
Jul 8, 2025
DonJayamanne
approved these changes
Jul 8, 2025
Contributor
Author
|
Thanks for helping with the hash. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webview (or its
acquireVsCodeApiinjector)adds the vscode api but also deletes the properties
window.parent,window.topandwindow.frameElement.This voilates the HTML Spec and makes problems with some code like
if (window.parent === window)todetect if we are running in an iframe.
Yes, this affects Hyrum's Law and https://xkcd.com/1172/ but detecting
acquireVsCodeApiobject itself feels to be cleaner anyway.