Add SecretStorage.keys() as proposed API

[gjsjohnmurray]

This PR implements #196616 by adding SecretStorage.keys() behind a secretStorageKeys proposed API gate.

[gjsjohnmurray]

/assign @TylerLeonhardt

[gjsjohnmurray]

https://github.com/gjsjohnmurray/vscode-extension-samples/tree/test-vscode-252804 provides a way of testing this by adding the following commands to authenticationprovider-sample:

• AuthenticationProvider Sample: Add a Secret Keyed by Timestamp
• AuthenticationProvider Sample: Show the Keys of Our Secrets
• AuthenticationProvider Sample: Delete All Our Secrets

Run the first one or more times, then run the second to see the keys, then the third to delete them all.

[gjsjohnmurray]

Any chance of getting this into this week's endgame?

[TylerLeonhardt]

Im on vacation til the 17th so it won't make this endgame

[TylerLeonhardt]

This has to be optional to start... because vscode.dev, github.dev, and maybe code serve-web & @vscode/test-web implement one of these providers and bring them in via:

vscode/src/vs/workbench/browser/web.api.ts

Line 237 in 73fbb0c

readonly secretStorageProvider?: ISecretStorageProvider;

since they don't have an implementation today, we should assume that this keys is optional... and error accordingly.

[TylerLeonhardt]

I can probably easily implement this for vscode.dev... but github.dev I don't have control over... so no promises.

[TylerLeonhardt]

edit: we don't need to worry about serve-web because of:

vscode/src/vs/code/browser/workbench/workbench.ts

Line 613 in 73fbb0c

? undefined /* with a remote without embedder-preferred storage, store on the remote */

[TylerLeonhardt]

edit: I don't think we need to worry about @vscode/test-web:
https://github.com/microsoft/vscode-test-web/blob/main/src/browser/main.ts#L266-L269

[gjsjohnmurray]

I have pushed an update. I hope I understood you correctly.

[TylerLeonhardt]

I've made the change for vscode.dev so that should work (in insiders.vscode.dev)

[TylerLeonhardt]

I like it!