feat: markdown-basics snippets: quote all lines #246871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this snippet just inserted "> " before the selected text, which is not very useful; particularly, when multiple paragraphs are selected, this will only quote the first one. Instead, we now prefix every line in the selection with "> ", so that it will all be quoted regardless of how many paragraphs are taken. This does also change the behavior in the case of no selected text slightly; previously it would insert "> []" (where "[]" indicates the selection; that is, it would put the insertion point after the quote marker). It now inserts "[> ]" instead (that is, the same text but it's all selected) so if you start typing you'll wind up removing the quote marker. Since using this snippet *not* on a selection seems like a roundabout way of writing "> " this seems like an acceptable tradeoff.
Contributor
|
should link a bug report with a screenshot of the old broken behaviour |
Contributor
Author
rzhao271
approved these changes
Apr 22, 2025
Contributor
|
@wolfgang42 the devs are auto assigned to issues |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this snippet just inserted
>before the selected text, which is not very useful; particularly, when multiple paragraphs are selected, this will only quote the first one:> This is a paragraph. This is another paragraph, which was supposed to be quoted but wasn't.Instead, we now prefix every line in the selection with
>, so that it will all be quoted regardless of how many paragraphs are taken.This does also change the behavior in the case of no selected text slightly; previously it would insert
> [](where[]indicates the selection; that is, it would put the insertion point after the quote marker). It now inserts[> ]instead (that is, the same text but it's all selected) so if you start typing you'll wind up removing the quote marker. Since using this snippet without a selection is just a roundabout way of typing > this seems like an acceptable tradeoff.Closes #247150.