#245665 fix early task exit with empty promptString input #246834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address issue #245665
tested with the following tasks.json file:
{ "version": "2.0.0", "tasks": [ { "command": "echo", "label": "echo", "args": [ "${input:test1}", "${input:test2}" ] } ], "inputs": [ { "id": "test1", "type": "promptString", "default": "", "description": "test1" }, { "id": "test2", "type": "promptString", "default": "", "description": "test2" } ] }entering empty strings into the prompts, before my change it ends early after
test1after it goes all the way through toechoboth inputs