Fix test items sorting in Testing Explorer to use natural file order #246352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
approved these changes
Apr 11, 2025
Member
|
Thanks! |
rzhao271
approved these changes
Apr 11, 2025
This was referenced Apr 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #245624
This PR improves test item sorting in Testing Explorer by replacing naive string comparison with compareFileNames() from vs/base/common/comparers.ts. This change ensures that files like test_1.py, test_2.py, test_10.py are sorted numerically instead of lexically. This fix also maintains the behavior of #173350, which fixes the behavior of #163449.
Reproduction steps before fix:
Reproduction steps after fix:
Location of change: vs/workbench/contrib/testing/browser/testingExplorerView.ts