Use parameter expansion to fetch envs for envVarCollections in shellIntegration-bash.sh #245264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix issue ShellIntegration-bash is not properly escaping windows paths microsoft#245260 where echo is causing characters to be interpreted instead of escaped
Contributor
|
Thanks for this. I agree, parameter expansion should be safer (since echo with special characters can cause some issues with those in windows path), and this would make things faster too since we avoid echo and cut (I think these spawn subprocesses) We also use the safer approach here with env reporting stuff. |
anthonykim1
approved these changes
Apr 2, 2025
Member
|
@meganrogge can you test this one too when you're back? |
This comment was marked as spam.
This comment was marked as spam.
meganrogge
pushed a commit
that referenced
this pull request
May 9, 2025
anthonykim1
added a commit
that referenced
this pull request
May 13, 2025
…sh shell integration (#248861) Recovery release)Reverting parameter expansion in bash shell integration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue ShellIntegration-bash is not properly escaping windows paths #245260 where echo is causing characters to be interpreted instead of escaped.
#245260 issue mostly affects insider release at the moment