Skip to content

tooltip text of close button is internationalized #245190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TylerLeonhardt merged 4 commits into from
Apr 1, 2025
Merged

tooltip text of close button is internationalized #245190

TylerLeonhardt merged 4 commits into from
Apr 1, 2025

Conversation

@manabu-nakamura
Copy link
Contributor

@manabu-nakamura manabu-nakamura commented Mar 31, 2025 •
edited
Loading

The tooltip text of the close button ("Close Banner") is not localized (#245194).
en
ja
First, it is internationalized in this PR.

I can not check this PR fully because the language pack can not be used in the code-oss (#245119).

Fixes #245194
TylerLeonhardt
TylerLeonhardt requested changes Apr 1, 2025
View reviewed changes
src/vs/workbench/browser/parts/banner/bannerPart.ts Outdated
const actionBarContainer = append(this.element, $('div.action-container'));
this.actionBar = this._register(new ActionBar(actionBarContainer));
const label = item.closeLabel ?? 'Close Banner';
const label = localize('closeBanner', "Close Banner");
Copy link
Member

@TylerLeonhardt TylerLeonhardt Apr 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the previous logic. Just wrap the Close Banner in the localize call.

Suggested change
const label = localize('closeBanner', "Close Banner");
const label = item.closeLabel ?? localize('closeBanner', "Close Banner");
Copy link
Contributor Author

@manabu-nakamura manabu-nakamura Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I rewrote it.
@TylerLeonhardt TylerLeonhardt added this to the April 2025 milestone Apr 1, 2025
@manabu-nakamura
Copy link
Contributor Author

manabu-nakamura commented Apr 1, 2025 •
edited
Loading

I could check this PR.
ja2
https://github.com/microsoft/vscode-loc/blob/main/i18n/vscode-language-pack-ja/translations/main.i18n.json#L3742-L3744:

		"vs/workbench/browser/parts/banner/bannerPart": {
+			"closeBanner": "バナーを閉じる",
			"focusBanner": "バナーにフォーカス"
		},
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Apr 1, 2025 •
edited
Loading

Thank you for contributing! This will be in version 1.100. The insider build of that will go out Thursday and the stable version of that will go out early next month.

You may not see the translation in insiders right away because translations do lag a bit, but I would say by end of next week it should be there.
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) April 1, 2025 12:47
@TylerLeonhardt TylerLeonhardt merged commit e5f20e7 into microsoft:main Apr 1, 2025
7 checks passed
@manabu-nakamura manabu-nakamura deleted the banner branch April 1, 2025 13:48
@manabu-nakamura
Copy link
Contributor Author

manabu-nakamura commented Apr 18, 2025

Will they be translated?
https://github.com/microsoft/vscode-loc/blob/main/i18n/vscode-language-pack-ja/translations/main.i18n.json:

			"closeBanner": "Close Banner"

			"closeBanner": "Close Banner",
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Apr 18, 2025

It'll take some time. Likely in the next stable release of VS Code 1.100 projected for early May
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@manabu-nakamura @TylerLeonhardt @bpasero @bhavyaus