Skip to content

Fix timeline view leaks event listeners #241607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bpasero merged 4 commits into from
Feb 24, 2025
Merged

Fix timeline view leaks event listeners #241607

bpasero merged 4 commits into from
Feb 24, 2025

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Feb 23, 2025

Fixes #241536
@jeanp413 jeanp413 mentioned this pull request Feb 23, 2025
Closed
bpasero
bpasero requested changes Feb 23, 2025
View reviewed changes
bpasero
bpasero previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanp413 please see my last change, I decided to encapsulate the disposable logic internally, I think we shouldn't expose the disposable to the interface outside.

Thanks!
@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 24, 2025
@bpasero bpasero enabled auto-merge (squash) February 24, 2025 07:12
chrmarti
chrmarti previously approved these changes Feb 24, 2025
View reviewed changes
@bpasero bpasero dismissed stale reviews from chrmarti and themself via f351379 February 24, 2025 07:45
@bpasero bpasero closed this Feb 24, 2025
auto-merge was automatically disabled February 24, 2025 11:36

Pull request was closed

@bpasero bpasero reopened this Feb 24, 2025
@bpasero bpasero enabled auto-merge (squash) February 24, 2025 11:36
@bpasero bpasero merged commit d894a16 into microsoft:main Feb 24, 2025
11 checks passed
@jeanp413 jeanp413 deleted the fix-241536 branch February 24, 2025 15:24
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@jeanp413 @bpasero @chrmarti