Skip to content

Fix terminal split view disposable leaked #241597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meganrogge merged 1 commit into from
Feb 24, 2025
Merged

Fix terminal split view disposable leaked #241597

meganrogge merged 1 commit into from
Feb 24, 2025

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Feb 22, 2025

Fixes #241596 plus some other disposables leaked
@jeanp413 jeanp413 changed the title Terminal split view disposable leaked Feb 22, 2025
@jeanp413 jeanp413 mentioned this pull request Feb 23, 2025
Closed
@meganrogge meganrogge added this to the February 2025 milestone Feb 24, 2025
meganrogge
meganrogge approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@meganrogge meganrogge requested a review from Tyriar February 24, 2025 06:17
@meganrogge meganrogge enabled auto-merge (squash) February 24, 2025 06:17
@meganrogge meganrogge merged commit 3889e52 into microsoft:main Feb 24, 2025
7 checks passed
@jeanp413 jeanp413 deleted the fix-241596 branch February 24, 2025 15:19
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@jeanp413 @Tyriar @meganrogge @legomushroom