Add panelTitleBadge color variables #240645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benibenj
requested changes
Feb 17, 2025
extensions/theme-solarized-light/themes/solarized-light-color-theme.json
Outdated
Show resolved
Hide resolved
extensions/theme-monokai-dimmed/themes/dimmed-monokai-color-theme.json
Outdated
Show resolved
Hide resolved
benibenj
requested changes
Feb 17, 2025
Contributor
benibenj
left a comment
benibenj
left a comment
There was a problem hiding this comment.
Thanks for the pull request. I suggested some changes. It would be nicer if the panel colors you added would use the activity bar colors as default color. Also, I don't think we need/should make any changes to the built in themes
benibenj
approved these changes
Feb 17, 2025
Contributor
benibenj
left a comment
benibenj
left a comment
There was a problem hiding this comment.
Thanks for the PR, works great!
benibenj
approved these changes
Feb 17, 2025
DonJayamanne
approved these changes
Feb 17, 2025
Contributor
Author
|
A few workflow runs are still awaiting approval. Would be awesome if someone could click that button. |
Contributor
Author
Thanks! Looks like everything is green now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
panelTitleBadge.backgroundandpanelTitleBadge.foregroundcolor variables to allow for more user customization. Use the defaults colors fromactivityBarBadge.Fixes #240510
/CC @benibenj