-
Notifications
You must be signed in to change notification settings - Fork 37.2k
Allow detection of powershell-preview snap #240054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
This comment was marked as outdated.
This comment was marked as outdated.
KexyBiscuit
added a commit
to AOSC-Tracking/vscodium
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
KexyBiscuit
added a commit
to AOSC-Tracking/vscodium
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Kexy Biscuit <kexybiscuit@aosc.io>
The powershell-preview snap provides `powershell-preview` command, make the regular expression detects that too. ```shell kexybiscuit@ProArtB550-CREATOR:~$ snap info powershell-preview name: powershell-preview summary: PowerShell for every system! publisher: Microsoft PowerShell✓ store-url: https://snapcraft.io/powershell-preview contact: https://github.com/powershell/powershell license: unset description: | PowerShell is an automation and configuration management platform. It consists of a cross-platform (Windows, Linux, and macOS) command-line shell and associated scripting language. See https://docs.microsoft.com/powershell/scripting/powershell-support-lifecycle for support details. commands: - powershell-preview snap-id: D0A7ph8R6LBXQ8rgs2ad06s8tjyeowsd tracking: latest/stable refresh-date: today at 14:12 CST channels: latest/stable: 7.6.0-preview.2 2025-01-27 (165) 77MB classic latest/candidate: ↑ latest/beta: ↑ latest/edge: 7.4.0-preview.3 2023-05-03 (142) 72MB classic installed: 7.6.0-preview.2 (165) 77MB classic kexybiscuit@ProArtB550-CREATOR:~$ sudo snap install powershell-preview --classic 2025-02-08T14:12:33+08:00 INFO Waiting for automatic snapd restart... powershell-preview 7.6.0-preview.2 from Microsoft PowerShell✓ installed kexybiscuit@ProArtB550-CREATOR:~$ command -v powershell-preview /snap/bin/powershell-preview ``` Co-authored-by: Garfield Lee <Garfield550@users.noreply.github.com> Signed-off-by: Kexy Biscuit <kexybiscuit@outlook.com>
Contributor
Author
Tyriar
approved these changes
Feb 21, 2025
lramos15
approved these changes
Feb 21, 2025
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Apr 7, 2025
Drop upstreamed patch from microsoft/vscode#240054. Co-authored-by: 白铭骢 (Mingcong Bai) (@MingcongBai) <jeffbai@aosc.io>
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Apr 7, 2025
Drop upstreamed patch from microsoft/vscode#240054. Co-authored-by: 白铭骢 (Mingcong Bai) (@MingcongBai) <jeffbai@aosc.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executable name can be
pwsh,pwsh-preview,powershell, orpowershell-preview. The new regular expression matches them all.Fixes #240053.