fix: workbench search use correct findMatch colors (fix #237909)

[simon-id]

Motivation

Fixes: #237909

With this user configuration, find match text color are improperly rendered when using Workbench Search (not the widget search):

    "workbench.colorCustomizations": {
        "editor.findMatchHighlightForeground": "#000000",
        "editor.findMatchHighlightBackground": "#ffffb4",
        "editor.findMatchForeground": "#000000",
        "editor.findMatchBackground": "#ff4cde"
    },

Before fix:

After fix:

Code changes

Add the inlineClassName field to the Workbench Search ModelDecorationOptions to properly render the editor.findMatchForeground and editor.findMatchHighlightForeground colors.

This field is copied directly from the ModelDecorationOptions in src/vs/editor/contrib/find/browser/findDecorations.ts, as the widget search properly renders the foreground colors.

vscode/src/vs/editor/contrib/find/browser/findDecorations.ts

Lines 286 to 318 in 37066ba

	public static readonly _CURRENT_FIND_MATCH_DECORATION = ModelDecorationOptions.register({
	description: 'current-find-match',
	stickiness: TrackedRangeStickiness.NeverGrowsWhenTypingAtEdges,
	zIndex: 13,
	className: 'currentFindMatch',
	inlineClassName: 'currentFindMatchInline',
	showIfCollapsed: true,
	overviewRuler: {
	color: themeColorFromId(overviewRulerFindMatchForeground),
	position: OverviewRulerLane.Center
	},
	minimap: {
	color: themeColorFromId(minimapFindMatch),
	position: MinimapPosition.Inline
	}
	});
	public static readonly _FIND_MATCH_DECORATION = ModelDecorationOptions.register({
	description: 'find-match',
	stickiness: TrackedRangeStickiness.NeverGrowsWhenTypingAtEdges,
	zIndex: 10,
	className: 'findMatch',
	inlineClassName: 'findMatchInline',
	showIfCollapsed: true,
	overviewRuler: {
	color: themeColorFromId(overviewRulerFindMatchForeground),
	position: OverviewRulerLane.Center
	},
	minimap: {
	color: themeColorFromId(minimapFindMatch),
	position: MinimapPosition.Inline
	}
	});

[simon-id]

Failing test looks unrelated and only happen on windows ? looks like a flaky tests but I don't know how to restart the job:

vscode API - network proxy support
       basic auth:
     Error: Unexpected status code (expected 418): 200

https://dev.azure.com/vscode/VSCode/_build/results?buildId=141565&view=logs&j=e5ed5edc-5ec6-5bfb-d1cb-ed7e8a6cb5eb&t=591b7a1b-7322-5ac3-b08e-eb7fe6b0ff14

[osortega]

@simon-id the Code OSS build is gone, could you please close and reopen the PR to trigger another build?

[simon-id]

@osortega done!

[osortega]

Thank you! ✨