Fix #4775: Escape user code before incorporating in a regex #236809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…$Sn rule processing
This was referenced Dec 22, 2024
Odessasm
approved these changes
Dec 22, 2024
mScott224
approved these changes
Dec 25, 2024
Contributor
Author
|
Ping @Yoyokrazy ? |
Collaborator
|
Shifting this to @alexdima as the last person that seems to have been involved with monarch related work |
Contributor
Author
|
ping @alexdima ? |
Contributor
Author
|
@Yoyokrazy perhaps another person can take a look? |
Contributor
Author
|
8 months later - any chance of this PR getting some love? |
alexdima
previously approved these changes
Jul 14, 2025
DonJayamanne
previously approved these changes
Jul 14, 2025
bpasero
approved these changes
Jul 14, 2025
alexdima
approved these changes
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as part of monarch $Sn rule processing.
There is a proposal to support such sanitization as part of the language, but it's not implemented yet. There are also libraries providing this service (eg lodash ), not sure what is the policy on adding dependencies to vscode.
This suggestion is just an added manual escaping, seems good enough.