-
Notifications
You must be signed in to change notification settings - Fork 37.2k
Fix PATH prepending when using Fish #232291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o the PATH after the shell integration
|
@Tyriar I applied the fix conditionally based on the shell being used. While further testing it, I noticed that the envMixin should be applied even on non-login shells with fish, because the variable {
"terminal.integrated.profiles.linux": {
"fish login": {
"path": "fish",
"args": [
"-l"
]
}
},
"terminal.integrated.defaultProfile.linux": "fish login"
} |
Tyriar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meganrogge could you review this please? I've only done a very high level review not digging into the details.
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
|
Thanks for working on this. I created this issue - we'll want to link it to this PR. #232495 |
Support Linux on EnvMixin to handle
fish_user_pathsbeing prepended to the PATH, overriding any configuration in the VSCode environment via thecontext.environmentVariableCollectionAPI.Fixes #232495
(The root problem was originally fixed for macOS on #99878 but it can also trigger when using the fish shell in other platforms)
More context: #226589 (comment)
cc @meganrogge