fix: Use a proper desktop name in package.json #231472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#154693 Initally, this part is required due to how Electron handles the prorotol registeration as in microsoft#56727 (comment) ( I also explained in microsoft#154693 (comment) ) However since microsoft@986b553 that part is no longer used for protocol registeration on Linux, and since Electron 18, Electron uses the desktop file name to set the `app_id` in Wayland, and it was given the wrong one. This change fixes the problem where running VS Code on Wayland would have the `app_id` of `code-url-handler` which is unreasonable.
deepak1556
approved these changes
Oct 16, 2024
Collaborator
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Change lgtm if url handling continues to work fine. Thanks for working on this PR!
TylerLeonhardt
approved these changes
Oct 17, 2024
13 tasks
This was referenced Nov 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154693
Initally, this part is required due to how Electron handles the prorotol registeration as in #56727 (comment) ( I also explained in #154693 (comment) )
However since 986b553 that part is no longer used for protocol registeration on Linux, and since Electron 18, Electron uses the desktop file name to set the
app_idin Wayland, and it was given the wrong one. This change fixes the problem where running VS Code on Wayland would have theapp_idofcode-url-handlerwhich is unreasonable.Test steps
ELECTRON_OZONE_PLATFORM_HINT=waylandapp_idofcode