Fix missing __dirname in --locate-shell-integration-path

[jamesharris-garmin]

This patch fixes #230584 by applying the recommended fix from:

https://masteringjs.io/tutorials/node/__dirname-is-not-defined

[Tyriar]

lgtm @bpasero could you verify this is the right way to do this now?

[bpasero]

Yes, it is:

vscode/src/main.ts

Line 24 in 6200f19

const __dirname = path.dirname(fileURLToPath(import.meta.url));

[bpasero]

But I would not call out "ESM" specifically, this is just the way of doing it now 🤔

[bpasero]

Follow up #231427

This is really a good catch and was missed during the ESM migration. We are bitten by the fact that the node.js types declare a global __dirname :-/

Update: I think we can have a ESLint rule to disallow...

[jamesharris-garmin]

Thanks everyone for the quick turn around on this.

[prasanthcakewalk]

May not be worth changing anything, but I think the import here:

vscode/src/vs/server/node/server.cli.ts

Line 10 in ffa1857

import path from 'path';

is not necessary, since dirname has already been imported here:

vscode/src/vs/server/node/server.cli.ts

Line 12 in ffa1857

import { dirname, extname, resolve, join } from '../../base/common/path.js';

I think the import line could be removed and
const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
could just be changed to
const __dirname = dirname(url.fileURLToPath(import.meta.url));
I could be wrong though; I'm not a typescript developer.

[bpasero]

Yes thanks, will address that.