228640: Hiding prelaunch task popup if the setting to hide it is enabled #231225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hello @connor4312 have added a feature setting to suppress prelaunch task notification popup, requesting your review.
Adding the screenshot of the setting for reference. |
Parasaran-Python
force-pushed
the
228640
branch
2 times, most recently
from
c5ca29d to
79eab4d
Compare
connor4312
reviewed
Oct 14, 2024
| markdownDescription: nls.localize({ comment: ['This is the description for a setting'], key: 'debug.hideLauncherWhileDebugging' }, "Hide 'Start Debugging' control in title bar of 'Run and Debug' view while debugging is active. Only relevant when {0} is not `docked`.", '`#debug.toolBarLocation#`'), | ||
| default: false | ||
| }, | ||
| 'debug.hidePreLaunchNotification': { |
Member
There was a problem hiding this comment.
Suggested change
| 'debug.hidePreLaunchNotification': { | |
| 'debug.hideSlowPreLaunchWarning': { |
| }, | ||
| 'debug.hidePreLaunchNotification': { | ||
| type: 'boolean', | ||
| description: nls.localize('debug.hidePreLaunchNotification', "Hide preLaunchTask popup."), |
Member
There was a problem hiding this comment.
Suggested change
| description: nls.localize('debug.hidePreLaunchNotification', "Hide preLaunchTask popup."), | |
| markdownDescription: nls.localize('debug.hidePreLaunchNotification', "Hide the warning shown when a `preLaunchTask` has been running for a while."), |
Parasaran-Python
force-pushed
the
228640
branch
from
79eab4d to
80d51b6
Compare
Contributor
Author
|
Made the requested changes @connor4312 please re-review. |
Parasaran-Python
force-pushed
the
228640
branch
from
80d51b6 to
ade48f5
Compare
connor4312
approved these changes
Oct 14, 2024
Member
|
thanks! |
joyceerhl
approved these changes
Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #228640
Adding a feature setting under debug section, to suppress the prelaunch task notification popup.