Skip to content

Conversation

@g-cappai
Copy link
Contributor

Fixes #203410

Updated click handler to use the actual href attribute value instead of the href property.

This change was necessary because the href property always resolves to an absolute URL starting with "https", which prevents delegation of link resolution to VS Code.

You can test this as described in the related issue. The expected behavior is that the anchor tag should now work in the same way as a markdown link in the markdown preview, allowing local files to open correctly in VS Code.

Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 18, 2024
@mjbvz mjbvz merged commit 59f6431 into microsoft:main Sep 18, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants