Register fold import action

[BABA983]

Close #130678

demo.mp4

[aeschli]

The folding model already knows which ranges are import ranges: type === FoldingRangeKind.Imports

See here as an example:

vscode/src/vs/editor/contrib/folding/browser/folding.ts

Line 877 in c955716

setCollapseStateForType(foldingModel, FoldingRangeKind.Comment.value, true);

Of course this only works for languages that have a provider. Your PR also has the same problem.

[BABA983]

The folding model already knows which ranges are import ranges: type === FoldingRangeKind.Imports

See here as an example:

vscode/src/vs/editor/contrib/folding/browser/folding.ts

Line 877 in c955716

setCollapseStateForType(foldingModel, FoldingRangeKind.Comment.value, true);

Of course this only works for languages that have a provider. Your PR also has the same problem.

I have update the code get regions from folding model.

Of course this only works for languages that have a provider. Your PR also has the same problem.

That seems to make sense to have a provider figure out what range is import range in different language?

[aeschli]

You can use the already existing function setCollapseStateForType:

vscode/src/vs/editor/contrib/folding/browser/foldingModel.ts

Line 436 in c955716

export function setCollapseStateForType(foldingModel: FoldingModel, type: string, doCollapse: boolean): void {

Depending on what extensions are installed, some language have rich language support and a folding provider, some don't.
For the languages that do not have a folding provider, folding ranges are computed using the indentation.
That might match the import sections, but must not.

[BABA983]

You can use the already existing function setCollapseStateForType

If we reuse the function we might need to know if the import range is collapsed or expanded.
Maybe we need a new function name toggleCollapseStateForType?

That might match the import sections, but must not.

If I understand right we should toggle fold import when there are provider provided? Like getFoldingRangeProviders here?

[aeschli]

If we reuse the function we might need to know if the import range is collapsed or expanded.
Maybe we need a new function name toggleCollapseStateForType?

Do you want to toggle or set? I assumed from the name of the command fold import it is about setting the state to folded.

The command will just be a no-op if there's folding provider that knows about imports. That's fine.

[BABA983]

If we reuse the function we might need to know if the import range is collapsed or expanded.
Maybe we need a new function name toggleCollapseStateForType?

Do you want to toggle or set? I assumed from the name of the command fold import it is about setting the state to folded.

The command will just be a no-op if there's fodling provider that knows about imports. That's fine.

Maybe toggle is better? Only fold import seems quite limited. Separating the two commands fold and unfold seems to give the user more flexibility. What do you think?

[aeschli]

Toggle is probably more useful.

[aeschli]

Thanks @BABA983 !