Skip to content

Support open in editor in git editor #226967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BABA983 wants to merge 2 commits into from
Closed

Support open in editor in git editor #226967

BABA983 wants to merge 2 commits into from

Conversation

@BABA983
Copy link
Contributor

@BABA983 BABA983 commented Aug 28, 2024

Close #153719

Maybe we should open in diffEditor here but I'm not sure if we can do this through DocumentLinkProvider

demo
@BABA983 BABA983 force-pushed the feature/git-editor-document-link-provider branch from c96cc57 to 6f8f22d Compare August 29, 2024 02:23
@lszomoru
Copy link
Member

lszomoru commented Oct 3, 2024

@BABA983, thank you very much for your contribution. I have built on top of your changes and created #230389. There were some minor changes that I had to make as your change was not covering the cases where multiple file names are being shown on one row (ex: rename).
@lszomoru lszomoru closed this Oct 3, 2024
@lszomoru lszomoru added this to the October 2024 milestone Oct 3, 2024
@lszomoru lszomoru added the on-release-notes Issue/pull request mentioned in release notes label Oct 3, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

on-release-notes Issue/pull request mentioned in release notes

2 participants

@BABA983 @lszomoru