Fix Image Preview transparency grid scaling #226505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangerman
commented
Aug 24, 2024
| padding: 0; | ||
| background-position: 0 0, 8px 8px; | ||
| background-size: 16px 16px; | ||
| border: 1px solid var(--vscode-imagePreview-border); |
Contributor
Author
There was a problem hiding this comment.
--vscode-imagePreview-border isn't actually defined because I think it was inadvertently removed in #122917 so this border wasn't even rendering before this PR.
Anyway, I've kept it on the grid because otherwise it'd get zoomed in as well.
mjbvz
approved these changes
Sep 3, 2024
bhavyaus
approved these changes
Sep 3, 2024
Collaborator
|
@dangerman I'm going to revert this PR for the upcoming release as it seems to have caused a few issues/regressions: #229019 #228263 Can you please take look at resubmitting this with a fix for those issues? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226095
transparency-grid-scaling-dark.mov
The transparency checkerboard grid pattern was getting larger when the image preview was zoomed in.
This PR moves it into its own div so it's not affected by the zoom.