Adopt ext host restart for custom text editors #225985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @bpasero |
sandy081
requested changes
Aug 26, 2024
sandy081
requested changes
Sep 5, 2024
Contributor
Author
|
@sandy081 I aligned the implementation with the notebook ones, just an FYI in case you haven't noticed. |
Member
|
@segevfiner Thanks for the changes. I will take a look. |
sandy081
requested changes
Sep 16, 2024
Contributor
Author
|
@sandy081 Updated. |
sandy081
requested changes
Sep 16, 2024
src/vs/workbench/contrib/customEditor/common/customTextEditorModel.ts
Outdated
Show resolved
Hide resolved
sandy081
requested changes
Sep 16, 2024
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
sandy081
approved these changes
Sep 17, 2024
bpasero
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically aligns the behavior between custom editors and custom text editors by handling the ext host
onWillStopevent in both of them.This doesn't yet solve the problem though. The editors are still orhpaned after the restart. Though if they are saved, we could probably restart them. Just need to figure out how... and to do it cleanly, we probably don't want the entire UI flickering tabs opening and closing :P When not saved, we probably want a warning. e.g. after a an extension host crash.
Related to #180514 #225410