Fix initial terminal dimensions are reload are incorrect #225554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanp413
commented
Aug 14, 2024
Comment on lines
-146
to
-151
| private readonly _onDidRequestFocus = this._register(new Emitter<void>()); | ||
| readonly onDidRequestFocus = this._onDidRequestFocus.event; | ||
| private readonly _onDidRequestSendText = this._register(new Emitter<string>()); | ||
| readonly onDidRequestSendText = this._onDidRequestSendText.event; | ||
| private readonly _onDidRequestFreePort = this._register(new Emitter<string>()); | ||
| readonly onDidRequestFreePort = this._onDidRequestFreePort.event; |
There was a problem hiding this comment.
Hi, is this PR going to be released in the next VSCode release?
lszomoru
approved these changes
Sep 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221580