Make regular text in markdown comments wrap in notebook editors. #224484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#224483. Without this, the comments inherit nowrap from monaco-list. I decided to fix it at this level because only in the notebook editor the comments seem to be ancestors of a monaco-list. I picked "initial" to indicate we are not actively trying to set anything, we are just trying to go back to normal, as the markdown renderer expects it.
bpasero
approved these changes
Aug 15, 2024
songjianet
approved these changes
Aug 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224483.
Without this, the comments inherit nowrap from monaco-list. I decided to fix it at this level because only in the notebook editor the comments seem to be ancestors of a monaco-list. I picked "initial" to indicate we are not actively trying to set anything, we are just trying to go back to normal, as the markdown renderer expects it.