Skip to content

Conversation

@BABA983
Copy link
Contributor

@BABA983 BABA983 commented Jul 20, 2024

Closes #92586

Provide a way to show gpu status
command
result

@deepak1556
Copy link
Collaborator

Thanks for working on this, the current result from getGPUFeatureStatus is limited and not really helpful for all cases. What would be better is to have an action in the help menu Help > Show GPU status and it should open a new window similar to process explorer that loads chrome://gpu url which will have all the necessary stats from the runtime.

@BABA983
Copy link
Contributor Author

BABA983 commented Jul 22, 2024

Thanks for working on this, the current result from getGPUFeatureStatus is limited and not really helpful for all cases. What would be better is to have an action in the help menu Help > Show GPU status and it should open a new window similar to process explorer that loads chrome://gpu url which will have all the necessary stats from the runtime.

Oh, that makes sense. I will work on this.

@BABA983 BABA983 force-pushed the feature/gpu-status branch from 7dd4ce9 to 6559290 Compare July 23, 2024 09:09
@BABA983
Copy link
Contributor Author

BABA983 commented Jul 23, 2024

@deepak1556 I got some updates in this PR.
Now it will open a new BrowserWindow to load the chrome://gpu URL with a Help > Show GPU status command.
I'm not sure if I should implement it in the browser environment since VSCode provides a Web edition.

  • In edge we can open edge://gpu or chrome://gpu which will redirect to edge://gpu automatically.
  • In firefox we can open about:support.
  • But I'm not finding a similar page in safari.
    help menu
    command plattle
    light
    dark
@deepak1556 deepak1556 added this to the August 2024 milestone Jul 23, 2024
@deepak1556
Copy link
Collaborator

The feature is only needed in desktop, for web users can get the info from respective browsers using the standard way.

Copy link
Collaborator

@justschen justschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, just a few comments

@bpasero
Copy link
Member

bpasero commented Sep 4, 2024

Sorry for the late review here but I wonder if the added files and services is a bit overkill for what we want to achieve here? I think a service is good if there are multiple users but I think here what we want is to open a window with the GPU info.

We could simply do that from the nativeHostMainService exposing a new method for it (such as the openDevtools method we already have) and put all the code there. In the end that would mean we just have 2 files to change?

@BABA983 BABA983 requested a review from bpasero September 9, 2024 14:56
bpasero
bpasero previously approved these changes Sep 9, 2024
@bpasero bpasero requested a review from deepak1556 September 9, 2024 15:53
@deepak1556
Copy link
Collaborator

Sorry I missed the ping on this. Changes LGTM but we have currently closed the main branch for release/1.94 preparation. I will merge this in once the branch is open again.

@BABA983
Copy link
Contributor Author

BABA983 commented Oct 15, 2024

@deepak1556 Could we merge into the main branch? Just resolved a merge conflict.

Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 deepak1556 enabled auto-merge (squash) October 15, 2024 08:53
@deepak1556 deepak1556 merged commit 47474f1 into microsoft:main Oct 15, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants