Show readonly filename decoration after revert that also resets mtime (fix #221014) #221023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
requested changes
Jul 9, 2024
Member
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
Yes, I like this. Two feedback:
- I think we can also apply the
lockedproperty alongsidereadonlywhich is for when a file system marked a file as not writeable - could we have 2 tests to test this if possible per text file model and stored file working copy?
Contributor
Author
|
I have added handling for |
Contributor
Author
|
Any chance of merging this for July? |
Contributor
Author
|
@bpasero can this be milestoned for August? |
sandy081
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #221014.
A "reserve-before-edit" type of SCM tool can result in a FileSystemProvider
statresult with both an earliermtimeand a changed (set)FilePermission.readonlybit inpermissions. VS Code was ignoring this, leaving the reverted document editable.