feature: enable typescript isolated modules #212913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2024
jrieken
requested changes
May 21, 2024
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
Thanks. This is looking good and I am surprised that TSC doesn't complain about all our const-enum usages
Member
👀 reading this again and some stackoverflow help resolves the mystery: only ambient/declared const enums are an issue |
jrieken
approved these changes
May 22, 2024
lszomoru
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212835