Skip to content

Add disassembly view context menu #212500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roblourens merged 7 commits into from
Apr 6, 2025
Merged

Add disassembly view context menu #212500

roblourens merged 7 commits into from
Apr 6, 2025

Conversation

@thegecko
Copy link
Contributor

@thegecko thegecko commented May 11, 2024 •
edited
Loading

This PR adds a context menu to the disassembly view with a couple of simple commands:

  • Copy Address: copies the address to the clipboard
  • Toggle Breakpoint: toggles a breakpoint for the focussed line

Screenshot 2024-05-11 at 11 03 36

Fixes: #129536

Relates with: #212501, #171548
@thegecko
Add disassembly context menu
786999f 
Signed-off-by: thegecko <rob.moran@arm.com>
@thegecko thegecko mentioned this pull request May 11, 2024
Open
@thegecko thegecko force-pushed the disassembly-context branch from d48a134 to 5fcdcbb Compare December 24, 2024 17:44
@roblourens roblourens added this to the April 2025 milestone Apr 6, 2025
roblourens
roblourens approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry that it took so long to merge this. Had to get it before its birthday 🙂. I think this is perfect. Thanks for the PR!
@roblourens roblourens enabled auto-merge April 6, 2025 00:57
@roblourens roblourens merged commit 61c1a70 into microsoft:main Apr 6, 2025
7 checks passed
@thegecko
Copy link
Contributor Author

thegecko commented Apr 6, 2025

Glad to see it merged @roblourens
@thegecko thegecko deleted the disassembly-context branch April 6, 2025 11:15
@jreineckearm jreineckearm mentioned this pull request Apr 16, 2025
Open
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@thegecko @roblourens @bpasero