Display Tab Indexes in VSCode

[swordjjjkkk]

I'd like a setting to decide show tab index.
there are two reasons i need to open this pull request.

1.It's useful for vim extension use <leader>+num to switch tab pages , and this won't disturb regular users, as it is disabled by default.
2.I tried compile an oss version , but the remote-ssh Extension not support oss version.

I look forward to any feedback or suggestions for improvement. Thank you for considering.

[swordjjjkkk]

@microsoft-github-policy-service agree

[moataz2002]

Nice to be merged

[benibenj]

Please create an issue for this feature and link this PR. Make sure to add a detailed description which describes the use case and the problem it solves.

FYI we added custom editor labels in this months release. It allows you change the name of the open editors/tabs. The setting name is workbench.editor.customLabels.patterns. But it won't give you any info on the tab index.

[swordjjjkkk]

Please create an issue for this feature and link this PR. Make sure to add a detailed description which describes the use case and the problem it solves.

FYI we added custom editor labels in this months release. It allows you change the name of the open editors/tabs. The setting name is workbench.editor.customLabels.patterns. But it won't give you any info on the tab index.

fixes #209533

[bpasero]

FYI we added custom editor labels in this months release. It allows you change the name of the open editors/tabs. The setting name is workbench.editor.customLabels.patterns. But it won't give you any info on the tab index.

I like the idea of having a new variable for the tab index for custom editor labels. Maybe one that is group-relative and one that is global?

[ghrejoe]

Please create an issue for this feature and link this PR. Make sure to add a detailed description which describes the use case and the problem it solves.

FYI we added custom editor labels in this months release. It allows you change the name of the open editors/tabs. The setting name is workbench.editor.customLabels.patterns. But it won't give you any info on the tab index.

It would be great if we could add it to this setting

[benibenj]

I would disagree with making this part of the workbench.editor.customLabels.patterns setting. Custom Labels have no relation to tabs/editor groups state. I would rather add a new setting workbench.editor.showIndex or something like this. This would just prepend the index of the editor in the group to the tab. I also check if we could make it part of one of the label format settings but I don't think that would work. What do you think @ghrejoe @bpasero?

[benibenj]

Just a quick review. Haven't tested yet. Also there is a merge conflict. But we still need to finish discussing if and how this should exactly work.

[ghrejoe]

I would disagree with making this part of the workbench.editor.customLabels.patterns setting. Custom Labels have no relation to tabs/editor groups state. I would rather add a new setting workbench.editor.showIndex or something like this. This would just prepend the index of the editor in the group to the tab. I also check if we could make it part of one of the label format settings but I don't think that would work. What do you think @ghrejoe @bpasero?

I agree with your statement. I used to think that I was worried about adding too many settings and causing redundancy. In fact, what I am more concerned about is being able to correctly switch to the corresponding editor when using the vim plugin through the [tab index] gt command. I hope to use this feature in the next release so that I don't have to look for plugins every once in a while to see if they can be implemented :)

[swordjjjkkk]

I have made the code modifications as required, specifically modifying the following:
1.Moved the settings into options.
2.Moved tab refresh to updateOptions.
3.Simplified the code using a ternary operator.
4.Renamed the setting from 'workbench.tabIndex.enabled' to 'workbench.editor.showTabIndex'.
5.Removed some irrelevant code.

[bpasero]

I am still not 100% sold that this cannot be configured through editor custom labels. We now limit this feature to how the index appears by hardcoding it (using just the number or number + dot) when people maybe want to configure this (see https://github.com/mkitt/tabline.vim where colon is used).

[benibenj]

@bpasero Custom Labels work solely based on the file path. It's possible that a custom label is rendered for a file which is not opened. In that case no index could be resolved.

Imagine the template ${tabIndex}: ${filename}.${extname}. If we render the custom label for a file which is not open for example in quick open ${tabIndex} could not be resolved to a number, hence we would have to render an empty string for it and so it would display : file.txt which is not wanted.

Also, if custom labels would use editor group information, it would probably strongly impact performance.

I wonder if we could still allow this to be customized without using custom labels. Any ideas?

[benibenj]

@swordjjjkkk Untitled editors are not getting the index prepended:

[vivodi]

Is this still relevant?

We will add the tab index with a predefined format for the moment. If the index format needs to be configurable in the future we can consider that later.

[bpasero]

I will review later

[bpasero]

This is not in a good state, esp. around the last commit that adds knowledge about how to render untitled into the tabs control.

I would expose a new option prefix on the label that is passed down based on this setting.

.

[Tyriar]

@benibenj I think this should get @bpasero's final approval considering the back and forth

[bpasero]

The display of tab index cannot be localised, which I think is fair considering we want to define how the experience is, but just wanted to note that maybe not in all languages {number}: {name} is natural.

[roachsinai]

Thanks a lot!

[ghrejoe]

I've already experienced this feature in the Code Insiders version, and I find it very useful.