-
Notifications
You must be signed in to change notification settings - Fork 37.2k
feat(web/lifecycleService): correct startupKind #206563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@samdenty any thoughts on https://web.dev/articles/navigation-and-resource-timing#acquiring_timings_in_application_code. I wonder about the actual perf impact of calling |
I think since this we're calling The observer pattern seems to be for when you want to subscribe to the latest events, instead of polling the API |
|
👍 , I think this can go in, I pushed some slight 👄 changes. One thing that will be received as some kind of regression potentially is that in web, we no longer just restore the previous view you had opened (you removed the |
|
Interesting: 5727c82 |
* fixes microsoft#206345 * fixes microsoft#206296 * fix: don't hard check isWeb * chore: review * cleanup * cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
This PR fixes #206345 & #206296.
Before the
startupKindwas only implemented for electron, but we can also do it on web (only found out cause chatgpt suggested). This makes the editor restoration logic better (and i'm sure other parts that use startupKind too)