Skip to content

Export ILocalizedString in nls.mock.ts #206449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hediet merged 1 commit into from
Mar 4, 2024
Merged

Export ILocalizedString in nls.mock.ts #206449

hediet merged 1 commit into from
Mar 4, 2024

Conversation

@a-stewart
Copy link
Contributor

@a-stewart a-stewart commented Feb 28, 2024

ILocalizedString was exported in 90f37e5#diff-ffc5ec6b53c5b0571dc77297b4aa72ebbba65eb8c8992f42f0c32905fa3eff1d

In order to be able to stub in the mock, we should export it in nls.mock.ts too.
@vscodenpa vscodenpa added this to the March 2024 milestone Feb 29, 2024
@hediet hediet merged commit 5f35467 into microsoft:main Mar 4, 2024
yiliang114 pushed a commit to yiliang114/vscode that referenced this pull request Mar 6, 2024
@a-stewart @yiliang114
Export ILocalizedString in nls.mock.ts (microsoft#206449)
18a492a
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

triage-needed

6 participants

@a-stewart @TylerLeonhardt @lramos15 @roblourens @hediet @vscodenpa