Skip to content

Fix memory leak in comments browser #205162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexr00 merged 2 commits into from
Feb 15, 2024
Merged

Fix memory leak in comments browser #205162

alexr00 merged 2 commits into from
Feb 15, 2024

Conversation

@werat
Copy link
Contributor

@werat werat commented Feb 13, 2024

The disposable objects stored in _commentThreadDisposables and _commentEditorDisposables are not disposed when the parent object is being disposed, leading to a memory leak.
@werat werat marked this pull request as ready for review February 14, 2024 07:50
@alexr00 alexr00 enabled auto-merge (squash) February 15, 2024 12:05
alexr00
alexr00 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
@alexr00 alexr00 added this to the February 2024 milestone Feb 15, 2024
@alexr00 alexr00 merged commit b71d2e5 into microsoft:main Feb 15, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@werat @lszomoru @alexr00