Stop the cursor from jumping when changing prefix in QuickAccess - v2 #204702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…QuickAcc…" This reverts commit 348e88d.
a-stewart
changed the title
Contributor
Author
|
@TylerLeonhardt - friendly ping for this. |
TylerLeonhardt
approved these changes
Mar 20, 2024
Member
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
Seems to work as expected. Thanks for following through with this!
Tyriar
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #162914
When changing the prefix, we should check the cursor position on the currently visible picker (if one exists), and if so we should set this as the position for the new picker.
In addition to #198821 - to avoid causing cursor jumps when switching between modes via commands (bug #204572) - it only retains the cursor position if the text content is unchanged.
Example of how this works using a console log:
