Only one subscriber for kernels for onDidChangeSelectedNotebooks #204417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyscho
force-pushed
the
fix-lots-of-kernel-subscribers
branch
from
bc1910a to
5f502f8
Compare
Contributor
Author
|
@microsoft-github-policy-service agree company="Jane Street" |
Member
|
Thanks for the contribution, will merge this change in next debt week. |
rebornix
approved these changes
Mar 6, 2024
aeschli
approved these changes
Mar 6, 2024
Member
|
Merged in main, thanks @andyscho for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue in #204416 (and microsoft/vscode-jupyter#15075)
This change just switches from each kernel that's added getting its own individual listener to just having a single listener for all the kernels. This way the number of listeners doesn't grow arbitrarily large to the point where it hits a threshold. Alternative solutions could include setting a higher threshold for the leakage monitoring for the relevant
Emitteror failing with a more user-friendly error if there are lots of kernels added, but this seems nicer.