fix: fallback to strings for non-executable libc.so.6 #202581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to confirm, this is also happening on Ubuntu 22 and 23. Strings does seem to get the right info though :-) |
khreenberg
force-pushed
the
fallback-to-strings-for-non-executable-libc
branch
from
cee0a47 to
77cface
Compare
khreenberg
force-pushed
the
fallback-to-strings-for-non-executable-libc
branch
from
77cface to
6a606e3
Compare
deepak1556
reviewed
Jan 16, 2024
Collaborator
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Thanks for catching this issue, left a minor change.
deepak1556
force-pushed
the
fallback-to-strings-for-non-executable-libc
branch
from
35466c8 to
63f3dcc
Compare
deepak1556
approved these changes
Jan 17, 2024
chrmarti
approved these changes
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback to
stringson hosts wherelibc.so.6is not executable. I don't know if usingstringsis a robust solution, but it resolves the issue for me on WSL distroUbuntu-Preview.Fixes #202580