avoid to enter the infinite loop when item.children is empty. #201701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectivecui
force-pushed
the
bugfix-create-folder
branch
2 times, most recently
from
b7fdd15 to
0b08603
Compare
Member
|
Do you have a linked bug and repro steps? I'm surprised there is any issue here given that the for loop should not iterate if empty |
Contributor
Author
I don't have a linked bug, but this bug bother me when I use code server mode. The reproduce step is that the user interaction become unresponsive when you create folders continuously and quickly, for example, create two folders quickly in a second, and then you can not do anything about code server vscode, because the while loop will not break out when the 2024-01-05.10.54.13.mov |
effectivecui
force-pushed
the
bugfix-create-folder
branch
from
0b08603 to
d422252
Compare
effectivecui
force-pushed
the
bugfix-create-folder
branch
from
d422252 to
7b871c6
Compare
lramos15
approved these changes
Jan 5, 2024
joyceerhl
approved these changes
Jan 5, 2024
Member
|
Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description:
When you create folders continuously and quickly, you will enter an infinite loop, causing the interaction to become unresponsive under the code server mode