Do not use respectMultiSelection for upload and paste #201145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
approved these changes
Feb 1, 2024
Member
lramos15
left a comment
lramos15
left a comment
There was a problem hiding this comment.
Makes sense, thanks for the contribution
bpasero
approved these changes
Feb 1, 2024
alexr00
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191359
The
explorerService.getContextmethod is used to determine where to upload or paste files. It accepts therespectMultiSelectionargument. When set to true, it disregards the currently focused item in the explorer and uses selected items as context. This is handy when copying multiple files, preventing copying only the focused one.However, for paste or upload actions, it's more practical to use the focused item as the target instead of the current selection. The paste action relies on the target file only to identify the destination folder, and uploading isn't available in the file context menu, so the multiSelection information isn't utilized anyway.